Added a cli argument to adjust gif playback rate. #53
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how animated .gifs encode frame_rate/fps information. they encode the delay between each individual frame.
Contributor
Author
|
Found the API for .gif playback. In .gif's each frame encodes how long you should wait (in milliseconds to delay the frame). So now I default to that behavior, unless the user overrides it with --frame_rate argument. |
atanunq
reviewed
Nov 4, 2020
Owner
atanunq
left a comment
There was a problem hiding this comment.
Hi!
Thank you very much for contributing, this is a great feature. Can you update the readme with the new flag and it's good to go
Contributor
Author
|
Sure no prob. I can do that later today. |
Owner
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I think viu is great! I needed to adjust the frame-rate, so I modified the code to allow this.
I'm just sharing my changes, use them if you want or don't, doesn't make a difference to me.
On a side note, there should be a way to read the frame rate from the .gif itself, but I don't use Rust daily and I don't know what the API is.
Cheers!