5200 supercart fixes #122
Merged
5200 supercart fixes #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them more in line with the rest of the file. Also fix some spacing.
AtariAge forums provide a recommended way to obtain links to posts - by pressing the "Share this post" action at the post's top right corner.
Bryan's cartridge PCB has the cartridge's name printed on it: "512K Super Cart" - it is as official a name as we can get. The term "Switchable" was so far used only in the context of "Switchable XEGS" cartridges, referring to their ability to be switched on/off (i.e. enabled/disabled). The 5200 Super Cart don't have this ability. Shift the word "5200" in the cartridge names to after the size, to make the names in line with other cartridges.
The $BFC0-$BFFF range was left marked as Hardware despite the cartridge not being present anymore, which casued the CPU emulation to access unallocated memory.
E.g. on an 64KB Super Cart, switching from bank 0 to bank 8 should not copy any memory, because the actual bank number is modulo 2 (as 64KB is 2 32KB banks), so the actual chosen bank number would remain 0. Solved by ensuring that active_cart->state always holds the actual bank number.
Member
|
@kr0tki sure go ahead and commit straight to master as much as you can! :-) |
Member
|
as for this particular commit - it just renames "Switching" to "Super", AFAICS. I am OK with that because I don't know anything about that cartridge nor the 5200. |
Contributor
Author
|
Yes, that commit is about the rename only. Well I guess I'm gonna merge it as it is - in any case, the names can be changed again later. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @joysfera and everyone,
I am going back to more active development after a long hiatus. This PR is mainly my attempt at testing The GitHub Process, and an opportunity to ask the following question: Petr, would you be fine with me usually bypassing the PR/review process and committing straight to master? I think I would use PRs/Issues only to propose/discuss changes worth debating.
Such as, for instance, this PR here. The scope is several assorted fixes to the Switchable 5200 cartridges introduced in #108. Most commits are non-controversial, but I have a feeling that cac0b4a may require some approval. Please comment.
I'd like to ask the potential reviewer to not merge the changes - I'm wishing to learn The Process by doing it myself.