Fix buffer over-read in generate_partial_pmpl_colls #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back and thanks! :) |
|
Thanks @pfusik for PR, based on my patch ;) Note the 5.0.0 is still crashing for me when run with the address sanitizer... |
|
@slajerek Feel free to submit more PRs or paste the ASAN log if you need help. |
|
I downgraded Atari800 and I have no more sanitizer errors or crashes. One of the issues was the one discovered here, but there are more related to certain video modes and draw_antic_4 messing out of bounds. The code was merged to my RetroDebugger so there's also a chance that my merge is not correct. I will go through this once again and post more details. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time no see! :)
Here's a one-line fix for reading outside the array boundary.