allow to publish raw data - fixes #3 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
atheriel
reviewed
Feb 6, 2020
Owner
|
I thought I had implemented this already, definitely an error on my part. Thanks for the submission. |
Contributor
Author
|
@atheriel thanks for valuable comments |
Contributor
Author
|
However now I think library should produce error, not a warning when the character body length is not equal to one. For interactive use warning would be 'okay'. But for non-interactive use it is better to fail fast rather than spending a lot of time on debug later (I believe in most of the cases this package will be used in non-interactive mode) |
… with lengt not equal to one
atheriel
reviewed
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.