Implement getLocalPath in Python #36
Conversation
add upstream branch
.gitignore
Outdated
| .DS_Store | ||
| .idea | ||
| *__pycache__* | ||
| *.edd-info* |
There was a problem hiding this comment.
Looks like .egg-info was misspelled - would you mind removing this entry?
python/commons/lab.py
Outdated
| class Paths(dj.Lookup): | ||
| definition = ... | ||
|
|
||
| def getLocalPath(self, path, local_os=None): |
There was a problem hiding this comment.
Keeping with Python convention, let's call this get_local_path, using snake_case rather thank CamelCase. Although this makes the method name different from Matlab, it fits better with rest of the naming conventions.
python/commons/lab.py
Outdated
| class Paths(dj.Lookup): | ||
| definition = ... | ||
|
|
||
| def getLocalPath(self, path, local_os=None): |
There was a problem hiding this comment.
Also this method doesn't use self, which usually suggests that this is better off as a staticmethod. Place @staticmethod right above the function definition, and you can skip the self argument.
There was a problem hiding this comment.
Complete oversight on my side - it does indeed use self as this is acting as placeholder class for DataJoint table implemented in Matlab.
Add getLocalPath in python