Fix freeze during the project download #8071
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embarc-gabriel
approved these changes
Jan 20, 2025
saintmatthieu
approved these changes
Jan 20, 2025
| ProjectInfo projectInfo, SnapshotInfo snapshotInfo, std::string path, | ||
| RemoteProjectSnapshotStateCallback callback, bool downloadDetached); | ||
|
|
||
| void StartSync(); |
Contributor
There was a problem hiding this comment.
This extra method for documentation purpose or is there another reason?
Member
Author
There was a problem hiding this comment.
I added it to make the code more understandable to indicate that the actual sync starts within mRequestsThread.
I should made StartSync private, though; fixed that.
When the download thread was scheduled before shared_ptr to RemoteProjectSnapshot was created, then lambda was failing to acquire a weak_ptr to self, resulting in the request not being processed. Now dispatch threads after the shared_ptr is initialized
4c464e8 to
075185b
Compare
Contributor
|
Tested. No freezes are observed when syncing is being resumed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the download thread was scheduled before shared_ptr to RemoteProjectSnapshot was created, lambda failed to acquire a weak_ptr to self, resulting in the request not being processed.
Now dispatch threads after the shared_ptr is initialized.
Recommended: