Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allow for initial id in repo create #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

allow for initial id in repo create #388

wants to merge 6 commits into from

Conversation

@BrianHung
Copy link

@BrianHung BrianHung commented Sep 24, 2024 •
edited
Loading

Allows for specified id in repo.create.

One thing: in the conversation about pre-defined ids and about loading from binary, does automerge.from clone the document that is passed in?

I'm wondering if this allows for the following:

const copy = {
  content: new Uint8Array([133, 111, 74, 131, ...]),
  id: ...
}

const doc = am.load(copy.content)
const handle = repo.create(doc, copy.id)

so that the initial value in repo.create shares ancestry with the binary that is passed in.

@adrianduke
Copy link

adrianduke commented Feb 1, 2025

Nudge for this functionality! I was just about to write this PR before I saw this... Can provide a hand if needed.

@BrianHung
Copy link
Author

BrianHung commented Feb 2, 2025

Feel free to jump into this discord thread: https://discord.com/channels/1200006940210757672/1287965416689238047/1288223592936374323 The main blocker is how should we handle conflicting ids.

@pvh pvh force-pushed the main branch 3 times, most recently from b5b124c to 12ae986 Compare April 3, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrianHung @adrianduke @pvh