Thanks to visit codestin.com
Credit goes to github.com

Skip to content

auto-bond ntn and test fix #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 15, 2024
Merged

auto-bond ntn and test fix #1059

merged 12 commits into from
Nov 15, 2024

Conversation

@tbssajal
Copy link
Contributor

@tbssajal tbssajal commented Oct 28, 2024 •
edited
Loading

  • Implemented auto-bonding by increasing LNTN conversion ratio
  • Tests for auto-bonding

@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.99%. Comparing base (6ef2894) to head (8c096d2).
Report is 82 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1059      +/-   ##
===========================================
+ Coverage    72.97%   72.99%   +0.03%     
===========================================
  Files           27       29       +2     
  Lines         3281     4580    +1299     
===========================================
+ Hits          2394     3343     +949     
- Misses         692      951     +259     
- Partials       195      286      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ScottRMalley
ScottRMalley reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ScottRMalley ScottRMalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add some new tests to double check this, otherwise I think it's looking pretty good.

@tbssajal tbssajal force-pushed the auto-bonding-inflation-reward branch 2 times, most recently from 3f0b03b to da45371 Compare October 30, 2024 18:38
@tbssajal tbssajal marked this pull request as ready for review October 30, 2024 18:41
vpiyush
vpiyush reviewed Oct 31, 2024
View reviewed changes
vpiyush
vpiyush approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@vpiyush vpiyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@tbssajal tbssajal force-pushed the auto-bonding-inflation-reward branch from da45371 to 59f9adb Compare November 5, 2024 16:39
@tbssajal
Copy link
Contributor Author

tbssajal commented Nov 5, 2024 •
edited
Loading

I had to do a bit of refactoring due to the fact that there are multiple protocol contracts that distribute rewards. Please review again if you have already reviewed @vpiyush @ScottRMalley @Jason-Zhangxin-Chen @lorenzo-dev1 @yazzaoui .

@tbssajal tbssajal requested a review from vpiyush November 6, 2024 02:21
@lorenzo-dev1 lorenzo-dev1 mentioned this pull request Nov 6, 2024
Closed
39 tasks
lorenzo-dev1
lorenzo-dev1 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@lorenzo-dev1 lorenzo-dev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, but LGTM!

vpiyush
vpiyush reviewed Nov 11, 2024
View reviewed changes
vpiyush
vpiyush reviewed Nov 11, 2024
View reviewed changes
vpiyush
vpiyush reviewed Nov 11, 2024
View reviewed changes
@ScottRMalley ScottRMalley force-pushed the auto-bonding-inflation-reward branch from dca4c50 to 3fc51cf Compare November 11, 2024 18:03
lorenzo-dev1
lorenzo-dev1 reviewed Nov 12, 2024
View reviewed changes
lorenzo-dev1
lorenzo-dev1 reviewed Nov 12, 2024
View reviewed changes
@ScottRMalley ScottRMalley force-pushed the auto-bonding-inflation-reward branch from 60c59dd to eac476d Compare November 14, 2024 13:06
@ScottRMalley ScottRMalley merged commit a72e4d5 into develop Nov 15, 2024
88 of 89 checks passed
@ScottRMalley ScottRMalley deleted the auto-bonding-inflation-reward branch November 15, 2024 09:38
@Jason-Zhangxin-Chen Jason-Zhangxin-Chen mentioned this pull request Oct 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpiyush vpiyush vpiyush approved these changes

@lorenzo-dev1 lorenzo-dev1 lorenzo-dev1 approved these changes

@ScottRMalley ScottRMalley ScottRMalley left review comments

@yazzaoui yazzaoui Awaiting requested review from yazzaoui yazzaoui is a code owner

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen Awaiting requested review from Jason-Zhangxin-Chen Jason-Zhangxin-Chen is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tbssajal @vpiyush @lorenzo-dev1 @ScottRMalley