Make pre-av hooks interactive and exit on error. #556
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusCommon Owner:
Review SLO: |
| Args: []string{"hook", "run", "--ignore-missing", "pre-av-sync"}, | ||
| Args: []string{"hook", "run", "--ignore-missing", "pre-av-sync"}, | ||
| Interactive: true, | ||
| ExitError: true, |
There was a problem hiding this comment.
Unlike av pr equivalent, this "Interactive" option might not work as expected. Because the terminal is under bubbletea's control in this code, the program exec-ed from this part wouldn't be able to control the terminal. For this reason, bubbletea has a special construct to pause its terminal control and exec the specified program https://pkg.go.dev/github.com/charmbracelet/bubbletea#ExecProcess
It's fine for now, but just let you know. I can follow up later.
Interactive for better user experience (show progress of the hook as it is running) and exit on error so that checks that fail actually stop the command.