feat: Add stack metadata to PR on creation #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aviator status
This PR was merged using Aviator. |
doratzeng
reviewed
Sep 7, 2022
| if didCreatePR { | ||
| action = "created" | ||
| } else { | ||
| // TODO: need to update the PR metadata possibly here |
Contributor
There was a problem hiding this comment.
what happens right now if we don't update the metadata here?
Contributor
Author
There was a problem hiding this comment.
Nothing right now since we don't use this on the server side. My plan is to finish this TODO then change the Aviator server side so that it's reading this information instead of trying to implicitly determine the shape of the stack based on how the PRs are arranged.
doratzeng
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will help us be more robust against weird things happen because we're trying to figure out the users intention based on how the PRs are arranged on GitHub.
This also will mean that we don't have to use the
avbeta-stackedprslabel since we can just read the metadata from the PR comment. I think this will be necessary to avoid accidentally injecting stacked PRs functionality into existing dev workflows.This is what it looks like:
