feat: Include parent pull in stack metadata, update metadata on stack submit #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stack submit This PR adds `parentPull` to stack metadata. It also will update the metadata whenever `CreatePullRequest` is called (_i.e._, when doing `av pr create` or `av stack submit`). We'll probably need to detect if things are bad™ on the server side of things and recommend running `av stack submit`, but at least this should make it so that the logic for constructing stacks is more explicit and intentional and consistent and less likely to do unexpected things.
Contributor
Aviator status
This PR was merged using Aviator. |
twavv
commented
Sep 12, 2022
| upstream, err := repo.RevParse(&git.RevParse{ | ||
| SymbolicFullName: true, | ||
| Rev: "HEAD@{u}", | ||
| Rev: fmt.Sprintf("%s@{u}", opts.BranchName), |
Contributor
Author
There was a problem hiding this comment.
this is an unrelated bug: we would always push whatever branch was currently checked out rather than the target branch.
Bad behavior (that's now fixed):
$ av stack submit
Creating pull request for branch 2022-09-12-one:
- pushing branch to GitHub (origin/2022-09-12-three)
...
(note that the pushing branch to bit is wrong)
| colors.UserInput(pull.Permalink), | ||
| "\n", | ||
| " - ", action, " pull request ", | ||
| colors.UserInput(pull.Permalink), "\n", |
Contributor
Author
There was a problem hiding this comment.
tweaked this just to be less visually noisy.
ghost
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
parentPullto stack metadata. It also will update the metadata wheneverCreatePullRequestis called (i.e., when doingav pr createorav stack submit).We'll probably need to detect if things are bad™ on the server side of things and recommend running
av stack submit, but at least this should make it so that the logic for constructing stacks is more explicit and intentional and consistent and less likely to do unexpected things.