Open editor when there's no title and no body #607
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusCommon Owner:
Review SLO: |
Summary of ChangesHello @draftcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to prevent the editor from opening unnecessarily when running av pr on a branch with an existing pull request that has a title but no body. The change correctly addresses this case. However, it introduces a side effect for creating new pull requests where the editor will not open if only a title is missing, leading to a command failure. My review includes a suggestion to refine the logic to handle both new and existing pull requests correctly.
| } | ||
|
|
||
| if opts.Edit || opts.Body == "" || opts.Title == "" { | ||
| if opts.Edit || (opts.Body == "" && opts.Title == "") { |
There was a problem hiding this comment.
This change correctly handles the case for existing PRs, but it introduces an issue when creating new PRs.
With this change, if a user tries to create a new PR with a body but no title (e.g., av pr -b "my body"), the editor will not open. The command will then attempt to create a PR with an empty title, which will fail. The previous behavior was to open an editor and pre-populate the title from the commit message, which is a better user experience.
The logic for opening the editor should be different for new and existing pull requests. For new PRs, the editor should open if either the title or body is missing. For existing PRs, it should only open if both are missing.
I suggest a more explicit condition to handle both cases correctly.
if opts.Edit ||
(existingPR == nil && (opts.Title == "" || opts.Body == "")) ||
(existingPR != nil && opts.Title == "" && opts.Body == "") {Previously, we didn't strip the PR metadata from the existing PR body, but with recent changes, we do. As a side effect, if an existing PR doesn't have a body (but has a title), it would open the editor unnecessarily with `av pr` command. Open it only when both title and body are empty.
c50cbc3 to
fb9b9fa
Compare
Previously, we didn't strip the PR metadata from the existing PR body,
but with recent changes, we do.
As a side effect, if an existing PR doesn't have a body (but has a
title), it would open the editor unnecessarily with
av prcommand.Open it only when both title and body are empty.