Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create BaseStackedView #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
draftcode wants to merge 1 commit into from
Closed

Create BaseStackedView #615

draftcode wants to merge 1 commit into from

Conversation

@draftcode
Copy link
Contributor

@draftcode draftcode commented Oct 28, 2025

No description provided.

@draftcode draftcode requested a review from a team as a code owner October 28, 2025 02:36
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 28, 2025 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Create BaseStackedView #615 👈 (this pr)
See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 28, 2025 •
edited
Loading

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • ✅ aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 cmd/av/adopt.go
    • 🔒 cmd/av/branch.go
    • 🔒 cmd/av/main.go
    • 🔒 cmd/av/next.go
    • 🔒 cmd/av/reparent.go
    • 🔒 cmd/av/restack.go
    • 🔒 cmd/av/switch.go
    • 🔒 cmd/av/sync.go
    • 🔒 internal/utils/uiutils/base_stacked_view.go
    • 🔒 internal/utils/uiutils/render_error.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.
❕ This PR modifies 237 lines, which is larger than the Review SLO threshold.

@aviator-app aviator-app bot requested a review from simsinght October 28, 2025 02:36
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 28, 2025

Summary of Changes

Hello @draftcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new BaseStackedView component within the uiutils package, designed to streamline the development of interactive command-line interfaces using the Bubble Tea framework. By abstracting common patterns for managing view stacks and error display, it significantly reduces boilerplate code across various av commands. This refactoring centralizes UI logic, making the codebase more maintainable and consistent, and prepares the ground for more complex interactive flows.

Highlights

  • New BaseStackedView Component: A new uiutils.BaseStackedView struct has been introduced to encapsulate common logic for managing a stack of Bubble Tea models (tea.Model) and rendering them, along with centralized error handling.
  • Refactored View Models: The adoptViewModel and syncViewModel structs now embed uiutils.BaseStackedView, delegating their Update and View methods to the base component and utilizing AddView for adding sub-views. This significantly reduces boilerplate code in these view models.
  • Centralized Error Handling: The renderError function and associated error variables (errNoGitHubToken, errParentNotAdopted) have been moved from cmd/av/render_error.go to internal/utils/uiutils/render_error.go and made public (RenderError, ErrNoGitHubToken, ErrParentNotAdopted), centralizing error rendering and common error definitions.
  • Code Simplification Across Commands: Various cmd/av files (adopt.go, branch.go, main.go, next.go, reparent.go, restack.go, switch.go, sync.go) have been updated to leverage the new uiutils.BaseStackedView and uiutils.RenderError functions, removing duplicated logic and lipgloss imports where the base view now handles it.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 28, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a BaseStackedView to abstract away common logic for managing stacked tea.Model views, which is a great refactoring. It significantly reduces code duplication in adoptViewModel and syncViewModel. The related changes of moving RenderError and shared error variables to the uiutils package also improve code organization. The implementation is solid. I have one suggestion to improve the clarity of the new BaseStackedView API.

internal/utils/uiutils/base_stacked_view.go
return nil
}

func (vm *BaseStackedView) Update(msg tea.Msg) tea.Cmd {
Copy link

@gemini-code-assist gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Update method shares its name with the tea.Model interface's Update method, but has a different signature. While the comment clarifies this, it could still be a source of confusion. To make the code more self-documenting and reduce the chance of misuse, I suggest renaming it to something that better describes its role, like UpdateViewStack.

This change would also require updating the call sites in cmd/av/adopt.go and cmd/av/sync.go.

Suggested change
func (vm *BaseStackedView) Update(msg tea.Msg) tea.Cmd {
func (vm *BaseStackedView) UpdateViewStack(msg tea.Msg) tea.Cmd {

@aviator-app aviator-app bot closed this in eb3e5b5 Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tulioz tulioz tulioz approved these changes

@simsinght simsinght Awaiting requested review from simsinght

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged-by-mq

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@draftcode @tulioz