Handle a case where no branch was chosen #618
Conversation
Current Aviator status
This PR was merged using Aviator. Stack
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusCommon Owner:
Review SLO: |
Summary of ChangesHello @draftcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly handles the case where no branches are selected for adoption in the remote adoption flow. This is a good improvement as it prevents an unnecessary git fetch operation and provides clear feedback to the user, making the behavior consistent with the local adoption flow. I have one suggestion to improve maintainability by reducing code duplication.
| if len(chosenTargets) == 0 { | ||
| return tea.Batch( | ||
| vm.AddView(uiutils.SimpleMessageView{Message: colors.SuccessStyle.Render("✓ No branch adopted")}), | ||
| tea.Quit, | ||
| ) | ||
| } |
There was a problem hiding this comment.
This logic for handling an empty chosenTargets slice is also present in (vm *adoptViewModel) initAdoption (lines 228-233). To improve maintainability and avoid code duplication, consider extracting this block into a private helper function within this file.
For example:
func noBranchesAdopted(adder func(tea.Model) tea.Cmd) tea.Cmd {
return tea.Batch(
adder(uiutils.SimpleMessageView{Message: colors.SuccessStyle.Render("✓ No branch adopted")}),
tea.Quit,
)
}And then call it like return noBranchesAdopted(vm.AddView) in both places.
No description provided.