Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check if the default branch is set when opening a repository #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
draftcode wants to merge 1 commit into from
Closed

Check if the default branch is set when opening a repository #622

draftcode wants to merge 1 commit into from

Conversation

@draftcode
Copy link
Contributor

@draftcode draftcode commented Oct 30, 2025 •
edited
Loading

We can check if the default branch at remote tracking branch
(refs/remotes/origin/HEAD) exists when opening a repository. By doing
so, we don't have to take context and do not have to do an error
handling in many situations.

@draftcode draftcode requested a review from a team as a code owner October 30, 2025 06:58
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 30, 2025 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Check if the default branch is set when opening a repository #622 👈 (this pr)
See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 30, 2025 •
edited
Loading

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • ✅ aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 cmd/av/adopt.go
    • 🔒 cmd/av/branch.go
    • 🔒 cmd/av/commit.go
    • 🔒 cmd/av/commit_common.go
    • 🔒 cmd/av/diff.go
    • 🔒 cmd/av/helpers.go
    • 🔒 cmd/av/init.go
    • 🔒 cmd/av/next.go
    • 🔒 cmd/av/orphan.go
    • 🔒 cmd/av/pr.go
    • 🔒 cmd/av/pr_status.go
    • 🔒 cmd/av/prev.go
    • 🔒 cmd/av/reorder.go
    • 🔒 cmd/av/reparent.go
    • 🔒 cmd/av/squash.go
    • 🔒 cmd/av/stack_foreach.go
    • 🔒 cmd/av/sync.go
    • 🔒 internal/actions/pr.go
    • 🔒 internal/git/git.go
    • 🔒 internal/git/git_test.go
    • 🔒 internal/treedetector/detector.go
    • 🔒 internal/git/gittest/repo.go
    • 🔒 internal/git/gitui/prune.go
    • 🔒 internal/sequencer/planner/planner.go
    • 🔒 internal/sequencer/planner/targets.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.
❕ This PR modifies 240 lines, which is larger than the Review SLO threshold.

@aviator-app aviator-app bot requested a review from simsinght October 30, 2025 06:58
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 30, 2025

Summary of Changes

Hello @draftcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how the application interacts with Git repository information, particularly concerning the default and current branches. By centralizing the determination of the default branch during repository opening and simplifying the API for various branch-related queries, the changes aim to reduce boilerplate code, improve error handling consistency, and enhance the overall robustness and maintainability of the codebase. This leads to cleaner and more predictable interactions with Git state throughout the application.

Highlights

  • Centralized Default Branch Determination: The default branch is now determined once during repository initialization (OpenRepo) and stored within the Repo struct, leading to more efficient and consistent access.
  • Simplified API for Branch Information: Methods such as DefaultBranch(), IsTrunkBranch(), TrunkBranches(), and CurrentBranchName() no longer require a context.Context parameter. Additionally, DefaultBranch() and IsTrunkBranch() no longer return an error, simplifying their usage across the codebase.
  • Early Error Handling for Default Branch: The system now errors out early during OpenRepo if the default branch cannot be determined, preventing potential issues downstream.
  • Robust Current Branch Detection: The CurrentBranchName method has been refactored to use go-git's Reference(plumbing.HEAD, false), providing more reliable detection and explicit handling of detached HEAD states.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 30, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice refactoring that moves the logic for determining the repository's default branch into the OpenRepo function. This allows for failing early if the default branch isn't configured, which improves robustness. It also simplifies many function signatures throughout the codebase by removing the need to pass a context.Context and handle errors for what is now a cached value. Additionally, I appreciate the replacement of a git shell-out with a native go-git implementation for getting the current branch name. The changes are extensive but look correct. I have one minor suggestion regarding a potentially misleading comment.

@draftcode draftcode force-pushed the update_metadata_semantics branch from 047eb15 to 55a6700 Compare October 30, 2025 07:34
@draftcode
Check if the default branch is set when opening a repository
26b0ce9 
We can check if the default branch at remote tracking branch
(refs/remotes/origin/HEAD) exists when opening a repository. By doing
so, we don't have to take context and do not have to do an error
handling in many situations.
@aviator-app aviator-app bot closed this in e3a2206 Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tulioz tulioz tulioz approved these changes

@simsinght simsinght Awaiting requested review from simsinght

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged-by-mq

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@draftcode @tulioz