[MER-875] Implement pushing branch during stack sync #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainankit
approved these changes
Jun 21, 2022
| state.Config = stackSyncConfig{ | ||
| Current: stackSyncFlags.Current, | ||
| Trunk: stackSyncFlags.Trunk, | ||
| NoPush: stackSyncFlags.NoPush, |
Contributor
There was a problem hiding this comment.
why NoPush instead of Push? And what's the default value?
Contributor
Author
There was a problem hiding this comment.
Default is false. Generally in Go, you structure things such that the zero-value is the default (false in the case of a bool type), and I'd rather have it be "default push" than "default no-push".
| case stacks.SyncAlreadyUpToDate: | ||
| fmt.Println("already up-to-date (no-op)") | ||
| _, _ = fmt.Fprint(os.Stderr, | ||
| colors.Success("already up-to-date"), "\n", |
Contributor
There was a problem hiding this comment.
do you mean colorSuccess.Sprint here and below?
Contributor
Author
There was a problem hiding this comment.
No, the colors package exports string functions because that's generally more useful to us here.
doratzeng
approved these changes
Jun 21, 2022
Contributor
Aviator status
This PR was merged using Aviator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.