Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@andrixb
Copy link

@andrixb andrixb commented Sep 8, 2017

No description provided.

@andrixb andrixb mentioned this pull request Sep 8, 2017
added new line at the eof
package.json Outdated
"build": "webpack -p --config ./webpack.prod.js",
"webpack-size": "webpack --config ./webpack.prod.js --json | webpack-bundle-size-analyzer"
}
"name": "showcase",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Just have one issue here. I see a lot of unnecessary diff in this file. It seems that the indentation has messed up. Please fix this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot replicate the issue on my machine by using an IDE or by using the github remote editor. Can you see it locally?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used 2-tabs in that file whereas your editor has changed it to spaces, thus that extra diff. I recommend you install an Editorconfig plugin for your editor as it will help it respect the .editorconfig file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this has been fixed in the last commit

Copy link
Owner

@aviaryan aviaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the browserlist in package.json?
https://github.com/ai/browserslist#packagejson
Any reasons why keeping a separate file might be practical?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants