Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: improve HTTP2 response handling for empty body responses #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve HTTP2 response handling for empty body responses #1242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions lib/https/h2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,29 @@ function requestH2(client, req, res, callback) {
svrRes.statusCode = statusCode;
// HTTP2 对响应内容格式要求太严格（NGHTTP2_PROTOCOL_ERROR）
if (!util.hasBody(svrRes, req)) {
h2Session.destroy();
svrRes = util.createTransform();
svrRes.statusCode = statusCode;
svrRes.push(null);
var wrapperStream = util.createTransform();
wrapperStream.statusCode = statusCode;

var hasReceivedData = false;
h2Session.on('data', function(chunk) {
hasReceivedData = true;
wrapperStream.push(chunk);
});

h2Session.on('end', function() {
if (!hasReceivedData) {
// 确实没有数据，正常结束
wrapperStream.push(null);
}
h2Session.destroy();
});

h2Session.on('error', function(err) {
wrapperStream.emit('error', err);
h2Session.destroy();
});

svrRes = wrapperStream;
}
svrRes.httpVersion = '1.1';
svrRes.headers = newHeaders;
Expand Down