Sparse matrix capabilities #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive sparse matrix capabilities to the XDiag library, adding support for coordinate (COO), compressed sparse row (CSR), and compressed sparse column (CSC) matrix formats. The implementation allows algorithms to use either on-the-fly matrix operations or precomputed sparse matrices for improved performance and memory efficiency.
Key changes include:
- Implementation of three sparse matrix formats with both 32-bit and 64-bit integer support
- Integration of sparse matrices with existing algorithms (eigenvalue computation, time evolution)
- Extensive testing and benchmarking infrastructure for sparse matrix operations
Reviewed Changes
Copilot reviewed 92 out of 191 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xdiag/algebra/sparse/*.hpp/.cpp | New sparse matrix types and operations (COO, CSR, CSC formats) |
| xdiag/algebra/apply_dispatch.* | Unified dispatch system replacing old fill-based approach |
| xdiag/algebra/matrix.cpp | Updated to use new dispatch system |
| tests/algebra/test_sparse_matrix.cpp | Comprehensive testing for sparse matrix functionality |
| julia/src/algebra/sparse/*.cpp | Julia bindings for sparse matrix operations |
| examples/usage_examples/main.* | Updated examples showing sparse matrix usage |
Comments suppressed due to low confidence (1)
xdiag/algebra/sparse/coo_matrix_fill.cpp:1
- Logic error: comparing V.n_rows with itself. Should be comparing V.n_rows with W.n_rows.
// SPDX-FileCopyrightText: 2025 Alexander Wietek <[email protected]>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 4 commits
November 2, 2025 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.