This repository was archived by the owner on Jul 31, 2025. It is now read-only.
internal/protocol/json: Reduce unmarshal allocs#376
Merged
jasdel merged 1 commit intoaws:masterfrom Sep 8, 2015
Merged
Conversation
Check PkgPath on StructField which will be empty for exported fields (http://golang.org/pkg/reflect/#StructField).
Contributor
Author
|
This is the same technique that the json standard library uses (https://github.com/golang/go/blob/932c1e3dd32f636ab3f25b23d9dcef194a577bca/src/encoding/json/encode.go#L1025) to check if a field is export so it should be correct. |
Contributor
|
Great find @bpot ! Thanks for submitting this PR. Allocations of the protocol marshallers is something we definitely want to improve. There are a series of benchmarks in I noticed this issue is present in several of the other marshallers, so similar fixes might be able to be applied to them also. I created #377 to track improving the protocol marshallers in general. |
jasdel
added a commit
that referenced
this pull request
Sep 8, 2015
internal/protocol/json: Reduce unmarshal allocs
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check PkgPath on StructField which will be empty for exported fields
(http://golang.org/pkg/reflect/#StructField).
We have an application which heavily uses DynamoDB and we are seeing a lot of allocations in
jsonutil/unmarshal. Based on a heap dump nearly 25% of the allocations (program wide) are coming fromstrings.ToLowerin unmarshalStruct: