This repository was archived by the owner on Jul 31, 2025. It is now read-only.
aws/signer/v4: Use const SHA256 for empty request body hash#738
Merged
jasdel merged 1 commit intoaws:masterfrom Jun 27, 2016
Merged
aws/signer/v4: Use const SHA256 for empty request body hash#738jasdel merged 1 commit intoaws:masterfrom
jasdel merged 1 commit intoaws:masterfrom
Conversation
Updated to use a const instead of recomputing the SHA256 for each request's empty body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use a const instead of recomputing the SHA256 for each
request's empty body.
Minor fix up of #731