Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: update assert for eval score to be float or int (instead of just… #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: update assert for eval score to be float or int (instead of just… #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/amazon_fmeval/eval_algorithms/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from functional import seq

from amazon_fmeval.constants import MIME_TYPE_JSON, MIME_TYPE_JSONLINES
from amazon_fmeval.constants import MIME_TYPE_JSONLINES
from amazon_fmeval.data_loaders.data_config import DataConfig


Expand Down Expand Up @@ -264,7 +264,7 @@ class ModelTask(Enum):
WOMENS_CLOTHING_ECOMMERCE_REVIEWS: DataConfig(
dataset_name=WOMENS_CLOTHING_ECOMMERCE_REVIEWS,
dataset_uri="dummy link",
dataset_mime_type=MIME_TYPE_JSON,
dataset_mime_type=MIME_TYPE_JSONLINES,
model_input_location="Review Text",
target_output_location="Recommended IND",
model_output_location=None,
Expand Down
5 changes: 4 additions & 1 deletion src/amazon_fmeval/eval_algorithms/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ class EvalOutputRecord:
sent_less_input_prob: Optional[str] = None
sent_more_output: Optional[str] = None
sent_less_output: Optional[str] = None
prompt: Optional[str] = None
sent_more_prompt: Optional[str] = None
sent_less_prompt: Optional[str] = None

def __str__(self):
return json.dumps(self._to_dict())
Expand Down Expand Up @@ -243,7 +246,7 @@ def from_row(row: Dict[str, Union[str, float]], score_names: List[str]) -> "Eval
)
non_score_columns[column_name] = value
else:
assert isinstance(value, float) # to satisfy Mypy
assert isinstance(value, float) or isinstance(value, int) # to satisfy Mypy
scores.append(EvalScore(name=column_name, value=value))

return EvalOutputRecord(
Expand Down