fix: unblock release pipeline #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezhu
approved these changes
Jan 23, 2024
| install_package() { | ||
| wheel_name=$(ls -t dist | head -n 1) | ||
| pip3 install --upgrade dist/$wheel_name | ||
| pip3 install --upgrade dist/$wheel_name --upgrade --upgrade-strategy only-if-needed --force-reinstall |
There was a problem hiding this comment.
Aren't --upgrade-strategy only-if-needed and --force-reinstall opposing ideas?
There was a problem hiding this comment.
Thanks! You're right --upgrade-strategy only-if-needed is the default option which is not needed here. I'll delete in another commit.
keerthanvasist
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Release pipeline gets blocked due to integration tests failed, add
--force-reinstalloption to pip install command to force re-install fmeval.While fixing this issue, ping
pandasto 2.1.4 as when 2.2.0 released 01/19/2024,there's error "ImportError: cannot import name 'ExtensionArrayFormatter' from 'pandas.io.formats.format'".
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.