feat: implement helper models used by evaluation algorithms #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR ports over a copy of the helper models from
fmeval.eval_algorithms.helper_models.helper_modelintofmeval.helper_models. The reason behind keeping the old code is that I don't to make half-baked changes that will break the existing evaluation algorithm implementations. Eventually, when all evaluation algorithms use the new Transform-based design, I will obviously get rid offmeval.eval_algorithms.helper_models.helper_model.Note that the new helper model code isn't exactly the same as the original code, but the changes are mainly minor cleanup.
This PR also implements the
create_shared_resourceutility function, which is used to create a Ray actor out of a "shared resource" (which is typically an object that consumes lots of memory, like a helper model). This utility function allows us to decouple the helper models from Ray, which is one problem that the current implementation ofBertscoreHelperModelfaces (notice how there is the@ray.remotedecorator on top of the class in our current implementation).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.