feat: update implementation of ClassificationAccuracySemanticRobustness to use Transform-based approach #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss to use Transform-based approach
danielezhu
commented
Mar 27, 2024
| }, | ||
| }, | ||
| ), | ||
| CASRTestCase( |
There was a problem hiding this comment.
I deleted two of the test cases, as we are already unit-testing all of the different perturbation variants. We've already done this for general semantic robustness.
danielezhu
commented
Mar 27, 2024
| ) | ||
| ], | ||
| ) | ||
| def test_classification_accuracy_semantic_robustness_evaluate_sample_with_model_output(self, test_case): |
There was a problem hiding this comment.
Getting rid of this test case as we no longer have model_output as a parameter in evaluate_sample. I've done the same thing for QA accuracy semantic robustness. The rationale is that users need to provide the model in order to get perturbed responses anyways, so it's just added work for them to get the model output first, and then pass it to the evaluate_sample method.
nathanng17
approved these changes
Mar 27, 2024
xiaoyi-cheng
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Title
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.