feat: fetch log probability jmespath from JS metadata #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezhu
approved these changes
May 2, 2024
| self._log_prob_compiler, f"Model {self._model_id} does not include input log probabilities in it's response" | ||
| ) | ||
| try: | ||
| assert ( |
There was a problem hiding this comment.
Why do we have this second assert when we have util.require above?
There was a problem hiding this comment.
It's there just to satisfy mypy. I could also make it ignore it, but I chose this path instead.
xiaoyi-cheng
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fetch log probability jmespath from JS metadata. This is a non-breaking change.
We were using a constant path, and so far that was also correct. But, going forward, for new models, it might not be. It is better to fetch the jmespath directly from metadata.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.