fix: update pinned sagemaker python sdk version and get_user_agent_extra util function #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tra util function
nathanng17
approved these changes
May 10, 2024
keerthanvasist
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In a recent release of the
sagemakerpython SDK (specifically, version2.218.1), they removed thedetermine_prefixutility function and re-implemented it asget_user_agent_extra_suffix. This PR updates our own user agent-related code to use this new util function and bumps the pinned dependency version forsagemaker.Note that the new header format that I use:
lib/fmeval#{version_number}is the new standard format that is being used.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.