feat: modify GeneratePrompt transform to take placeholder_dict #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezhu
suggested changes
Jun 7, 2024
danielezhu
approved these changes
Jun 8, 2024
oyangz
approved these changes
Jun 10, 2024
oyangz
added a commit
that referenced
this pull request
Jun 11, 2024
* feat: add SaveStrategy to allow flexibility in saving localized evaluation outputs (#281) * feat: modify GeneratePrompt transform to take placeholder_dict (#288) * feat: modify GeneratePrompt transform to take placeholder_dict * fix: unit test * fix: requested changes --------- Co-authored-by: keerthanvasist <[email protected]> Co-authored-by: Xiaoyi Cheng <[email protected]>
danielezhu
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Hey @xiaoyi-cheng, I missed this small detail when reviewing your PR last week. I added a comment for record-keeping purposes. I'll submit a PR to fix this soon.
| """ | ||
| super().__init__(input_keys, output_keys, prompt_template) | ||
| super().__init__(input_keys, output_keys, prompt_template, placeholder_to_record_key) | ||
| self.register_input_output_keys(input_keys, output_keys) |
There was a problem hiding this comment.
Shoot, I didn't catch this before the PR got merged, but we will need to update the call to self.register_input_output_keys to handle the case where placeholder_to_record_key is non-null.
input_keys_to_register = list(placeholder_to_record_keys.values()) if placeholder_to_record_key else input_keys
self.register_input_output_keys(input_keys_to_register, output_keys)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently GeneratePrompt transform can only substitute default placeholder
$model_inputwithdatafield.This PR will support
placeholder_data_dict(#273)Description of changes:
placeholder_keys_dictwill be placeholder keys to input keys mapping, but in this way it only supports transform 1 prompt with one placeholder dict. See unit test for use caseBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.