feat: add error field in EvalScore #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthanvasist
suggested changes
Jun 26, 2024
keerthanvasist
previously approved these changes
Jun 27, 2024
danielezhu
suggested changes
Jun 27, 2024
| ] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("file_name", ["my_dataset.jsonl", "my_dataset"]) |
There was a problem hiding this comment.
Can you please parametrize ds_items and the expected json_obj values so that you can combine this test with the previous test (test_save_dataset)?
keerthanvasist
approved these changes
Jun 27, 2024
danielezhu
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add error fields in
EvalScore. Ignore None value when aggregate dataset score.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.