Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zicanl-amazon
Copy link
Contributor

@zicanl-amazon zicanl-amazon commented Mar 14, 2025

*Issue #

*Description of changes: Ensure that your GitHub workflows cannot be automatically triggered when a non-contributor submits a pull request or using similar event. Especially if you have workflows that run integration tests, please ensure a manual approval step is added before triggering the workflow.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zicanl-amazon zicanl-amazon force-pushed the add-workflow-approval branch from c7ed197 to 26147f1 Compare March 14, 2025 00:33
Copy link
Contributor

@oyangz oyangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check why the unit tests are failing?

Approving since this only changes the approval workflow.

@Satish615
Copy link
Contributor

Satish615 commented Apr 1, 2025

please remove internal ticket links from the PR. Unit tests are failing on older environments, which is unrelated to this change. Approving to unblock for now

@Satish615 Satish615 temporarily deployed to manual-approval April 3, 2025 05:41 — with GitHub Actions Inactive
@zicanl-amazon zicanl-amazon merged commit b7a6421 into aws:main Apr 4, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants