os: detect PMULL support before enabling accelerated crc32c on ARM #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue axboe#1239 shows a crash on a FUJITSU/A64FX ARM platform at the following line: crc/crc32c-arm64.c: 64 t1 = (uint64_t)vmull_p64(crc1, k2); On armv8 PMULL crypto instructions like vmull_p64 are defined as optional (see google/crc32c#6 (comment) and dotnet/runtime#35143 (comment) ). Avoid the crash by gating use of the hardware accelerated ARM crc32c path behind runtime detection of PMULL. Fixes: axboe#1239 Signed-off-by: Sitsofe Wheeler <[email protected]> Tested-by: Yi Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1239 shows a crash on a FUJITSU/A64FX ARM platform at the
following line:
crc/crc32c-arm64.c:
64 t1 = (uint64_t)vmull_p64(crc1, k2);
On armv8 PMULL crypto instructions like vmull_p64 are defined as
optional (see
google/crc32c#6 (comment) and
dotnet/runtime#35143 (comment) ).
Avoid the crash by gating use of the hardware accelerated ARM crc32c
path behind runtime detection of PMULL.
Fixes: #1239
Signed-off-by: Sitsofe Wheeler [email protected]
Tested-by: Yi Zhang [email protected]