Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: remove useless field in header #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaoImin merged 8 commits into from
Apr 27, 2023
Merged

refactor: remove useless field in header #1152

KaoImin merged 8 commits into from
Apr 27, 2023

Conversation

@KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Apr 13, 2023 •
edited
Loading

What this PR does / why we need it:

This PR remove some useless field in block header structure.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner April 13, 2023 07:01
@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 18, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 18, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 18, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 18, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

peterzhb
peterzhb previously approved these changes Apr 23, 2023
View reviewed changes
felicityin
felicityin previously approved these changes Apr 26, 2023
View reviewed changes
@KaoImin KaoImin dismissed stale reviews from felicityin and peterzhb via 9c71e6b April 26, 2023 11:14
@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 26, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 26, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin force-pushed the change-header branch 3 times, most recently from 671dccf to 4166993 Compare April 27, 2023 08:13
@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 27, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 27, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Apr 27, 2023
Merged via the queue into main with commit 2cb483c Apr 27, 2023
@KaoImin KaoImin deleted the change-header branch April 27, 2023 08:52
@KaoImin KaoImin mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust wenyuanhust is a code owner automatically assigned from axonweb3/axon-dev

@hongda3141 hongda3141 Awaiting requested review from hongda3141 hongda3141 is a code owner automatically assigned from axonweb3/axon-dev

3 more reviewers

@liya2017 liya2017 liya2017 approved these changes

@felicityin felicityin felicityin approved these changes

@peterzhb peterzhb peterzhb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KaoImin @peterzhb @liya2017 @felicityin