Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix modexp gas cost #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaoImin merged 1 commit into from
May 9, 2023
Merged

fix: fix modexp gas cost #1183

KaoImin merged 1 commit into from
May 9, 2023

Conversation

@driftluo
Copy link
Contributor

@driftluo driftluo commented May 9, 2023

What this PR does / why we need it:

This PR fixes modexp gas cost overflow panic

https://github.com/ethereum/go-ethereum/blob/a03490c6b2ff0e1d9a1274afdbe087a695d533eb/core/vm/contracts.go#L317-L318

exp may zero, it can not subtract with one

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@driftluo driftluo requested a review from a team as a code owner May 9, 2023 10:02
@driftluo driftluo requested review from hongda3141 and liya2017 May 9, 2023 10:02
@github-actions github-actions bot added the bugfix label May 9, 2023
@KaoImin KaoImin added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 950a9bb May 9, 2023
@KaoImin KaoImin deleted the fix-modexp-gas-cost branch May 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongda3141 hongda3141 Awaiting requested review from hongda3141 hongda3141 is a code owner automatically assigned from axonweb3/axon-dev

@liya2017 liya2017 Awaiting requested review from liya2017 liya2017 is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driftluo @KaoImin