Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(API): add latest parameter for BlockId type #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaoImin merged 2 commits into from
Jun 14, 2023
Merged

fix(API): add latest parameter for BlockId type #1233

KaoImin merged 2 commits into from
Jun 14, 2023

Conversation

@hongda3141
Copy link
Contributor

@hongda3141 hongda3141 commented Jun 13, 2023 •
edited
Loading

add parameter latest so that function get_block_by_id could get the latest header

What this PR does / why we need it:

This PR

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

fix: add parameter latest
8152e02 
add latest parameter so that could get latest header
@hongda3141 hongda3141 requested a review from a team as a code owner June 13, 2023 13:17
@hongda3141 hongda3141 requested review from KaoImin and ahonn June 13, 2023 13:17
@hongda3141
Copy link
Contributor Author

hongda3141 commented Jun 13, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Jun 13, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Unit Tests

Please check ci test results later.

KaoImin
KaoImin previously approved these changes Jun 14, 2023
View reviewed changes
@hongda3141
Copy link
Contributor Author

hongda3141 commented Jun 14, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Jun 14, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit 740d962 Jun 14, 2023
@KaoImin KaoImin deleted the @michael/axon_api branch July 7, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahonn ahonn Awaiting requested review from ahonn ahonn is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hongda3141 @KaoImin