Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: writing version atomically #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaoImin merged 2 commits into from
Jun 28, 2023
Merged

fix: writing version atomically #1242

KaoImin merged 2 commits into from
Jun 28, 2023

Conversation

@blckngm
Copy link
Contributor

@blckngm blckngm commented Jun 26, 2023 •
edited by liya2017
Loading

What this PR does / why we need it:

To avoid partial writes. This also fixes the problem that the file isn't truncated when writing the current version, so part of the previous version might be left in the file.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@blckngm blckngm requested a review from a team as a code owner June 26, 2023 13:01
@blckngm blckngm requested review from driftluo and hongda3141 June 26, 2023 13:01
KaoImin
KaoImin previously approved these changes Jun 26, 2023
View reviewed changes
@blckngm
fsync correctly
6bac3b5 
fsync, rename and fsync parent directory
@blckngm blckngm force-pushed the atomic-write-version branch from 6e26ed5 to 6bac3b5 Compare June 26, 2023 14:57
@KaoImin
Copy link
Contributor

KaoImin commented Jun 27, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Jun 27, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Unit Tests

Please check ci test results later.

@KaoImin KaoImin merged commit c0523c5 into axonweb3:main Jun 28, 2023
@blckngm blckngm deleted the atomic-write-version branch June 30, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driftluo driftluo Awaiting requested review from driftluo driftluo is a code owner automatically assigned from axonweb3/axon-dev

@hongda3141 hongda3141 Awaiting requested review from hongda3141 hongda3141 is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blckngm @KaoImin