Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(consensus): correct receipts root #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaoticlonghair merged 1 commit into from
Aug 11, 2023
Merged

fix(consensus): correct receipts root #1270

chaoticlonghair merged 1 commit into from
Aug 11, 2023

Conversation

@chaoticlonghair
Copy link
Contributor

@chaoticlonghair chaoticlonghair commented Jul 12, 2023 •
edited
Loading

What this PR does / why we need it:

This PR will fix the incorrect receipts root.

Which issue(s) this PR fixes:

Which toolchain this PR adaption:

Breaking Change:

  • Receipts root for all blocks are changed.

Special notes for your reviewer:

This PR should be released with the migrate sub-command together, which will push request later.

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@chaoticlonghair

This comment was marked as off-topic.

Sign in to view
@axon-bot

This comment was marked as outdated.

Sign in to view
@chaoticlonghair chaoticlonghair force-pushed the yangby/bugfix/incorrect-receipts-root branch from b48661f to f521f96 Compare July 13, 2023 01:57
@chaoticlonghair

This comment was marked as off-topic.

Sign in to view
@axon-bot

This comment was marked as outdated.

Sign in to view
@Flouse

This comment was marked as off-topic.

Sign in to view
@axon-bot

This comment was marked as outdated.

Sign in to view
@chaoticlonghair

This comment was marked as off-topic.

Sign in to view
@axon-bot

This comment was marked as outdated.

Sign in to view
@chaoticlonghair chaoticlonghair force-pushed the yangby/bugfix/incorrect-receipts-root branch from f521f96 to 0d517f9 Compare August 10, 2023 02:33
@chaoticlonghair

This comment was marked as off-topic.

Sign in to view
@axon-bot

This comment was marked as outdated.

Sign in to view
@chaoticlonghair chaoticlonghair marked this pull request as ready for review August 10, 2023 02:36
@chaoticlonghair chaoticlonghair requested a review from a team as a code owner August 10, 2023 02:36
@chaoticlonghair chaoticlonghair requested review from Flouse, KaoImin, Simon-Tl, ahonn and driftluo and removed request for Simon-Tl and ahonn August 10, 2023 02:36
KaoImin
KaoImin reviewed Aug 10, 2023
View reviewed changes
@chaoticlonghair chaoticlonghair added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit d47eb0b Aug 11, 2023
@chaoticlonghair chaoticlonghair deleted the yangby/bugfix/incorrect-receipts-root branch August 11, 2023 07:43
This was referenced Aug 16, 2023
Closed
Closed
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
@chaoticlonghair
fix(consensus): correct receipts root (#1270)
9ea9f41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo Awaiting requested review from driftluo

+1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Receipts should support EIP-2718 since Tansactions already support EIP-2930 and EIP-1559 The implemention of receipts root in block is incorrect

4 participants

@chaoticlonghair @Flouse @KaoImin