Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: add merge_group to enable GitHub merge queue #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaoImin merged 1 commit into from
Aug 10, 2023
Merged

ci: add merge_group to enable GitHub merge queue #1313

KaoImin merged 1 commit into from
Aug 10, 2023

Conversation

@chaoticlonghair
Copy link
Contributor

@chaoticlonghair chaoticlonghair commented Aug 9, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds merge_group to enable GitHub merge queue.

Without merge_group in workflows, the merge queue is fancy but not totally useless.

GitHub Docs has written:

You must use the merge_group event to trigger your GitHub Actions workflow when a pull request is added to a merge queue.

I only add the 5 basic checks as required checks for merging a PR.

Which issue(s) this PR fixes:

Fixes #1312.

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@chaoticlonghair chaoticlonghair requested a review from a team as a code owner August 9, 2023 06:36
@chaoticlonghair chaoticlonghair requested review from Flouse, KaoImin and driftluo and removed request for Simon-Tl and felicityin August 9, 2023 07:24
@KaoImin
Copy link
Contributor

KaoImin commented Aug 9, 2023

@Simon-Tl Please confirm this.

@KaoImin KaoImin added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 5bb8e5d Aug 10, 2023
@chaoticlonghair chaoticlonghair deleted the yangby/bugfix/fix-merge-queue branch August 10, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo Awaiting requested review from driftluo

+2 more reviewers

@KaoImin KaoImin KaoImin approved these changes

@Simon-Tl Simon-Tl Simon-Tl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip_changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Bug: Invalid GitHub merge queue configurations

5 participants

@chaoticlonghair @KaoImin @Flouse @Simon-Tl