Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: relax file requirements, improve IO errors #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2023
Merged

feat: relax file requirements, improve IO errors #640

merged 3 commits into from
Sep 29, 2023

Conversation

@manyinsects
Copy link
Contributor

@manyinsects manyinsects commented Sep 29, 2023 •
edited
Loading

Behaviour changes:

  • Readme file doesn't need to exist anymore, is now optional, with a warning being output
  • oranda now hard errors when a hardcoded mdbook path can't be found
  • local logo paths will now error when they're not found
  • additional pages paths will also error when they're not found

TODO:

  • Add backticks around the path in the error message for readability
  • Update docs to mention that you don't need a readme circa 0.5.0

@manyinsects
Copy link
Contributor Author

manyinsects commented Sep 29, 2023

Screenshots:

@manyinsects manyinsects mentioned this pull request Sep 29, 2023
Closed
@manyinsects manyinsects added this to the oranda-0.5.0 milestone Sep 29, 2023
ashleygwilliams
ashleygwilliams reviewed Sep 29, 2023
View reviewed changes
@manyinsects manyinsects merged commit 73946dc into main Sep 29, 2023
@manyinsects manyinsects deleted the fix/path-fallback branch September 29, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

oranda-0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@manyinsects @ashleygwilliams