image: add extra test for monochrome images #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to fix the TODO (whether the decoded image was actually valid)
but found that it wasn't:
- The size wasn't correct. The TinyGo logo was actually 304x255 in
size, not 299x255 (it looks like it was created with a tool that
assumes every row starts at a byte aligned line, which image.Mono
doesn't).
- There seems to be a problem when the image is decoded as a
pixel.Monochrome, but I haven't yet figured out why.
This test needs tinygo-org/drivers#683 to pass, but I think it's a useful test regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs tinygo-org/drivers#683 to be merged first.