image: modify QOI to allow for loading from []byte #1
Conversation
Signed-off-by: deadprogram <[email protected]>
aykevl
left a comment
There was a problem hiding this comment.
Can you give a bit more context why this is needed?
Typically I'll include an image using //go:embed as a string, so that it doesn't take up any RAM (while a []byte would):
https://github.com/aykevl/things/blob/cb1f745f268d6e51daacc670b6282d28a095c4c1/badge/images.go#L13-L21
| return nil, errQOIUnsupportedColorSpace | ||
| } | ||
| img := &QOI[T]{ | ||
| data: []byte(data), |
There was a problem hiding this comment.
This will result in a heap allocation the size of the image, which is probably not what you want.
We could unsafely cast the string to a byte slice using unsafe.Slice (and then make sure to never modify it) to avoid this. It's a bit dangerous though.
|
What I really want to do is to load it directly via |
|
What do you mean exactly? That you'd load the entire image file into RAM, or only chunks of it on-demand? |
This PR modifies
imageto allows for a QOI format to be loaded from a []byte. It is a lot more flexible for working with various formats in embedded files.