refactor: overlayとbackgroundでdeprecated APIを使っている部分を修正
#506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the use of deprecated API calls by converting calls to .overlay and .background into their trailing-closure forms. The changes refactor the UI code in various view components to use the updated closure syntax for improved clarity and compatibility.
- Refactored .overlay calls to use closure syntax.
- Refactored .background calls to use closure syntax.
- Ensured consistency in the visual presentation across multiple UI components.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MainApp/Theme/ThemeTab.swift | Updated overlay syntax using trailing closure. |
| MainApp/Theme/ThemeShareView.swift | Replaced background() parameter with closure block. |
| MainApp/Setting/FontSizeSetting/FontSizeSettingItemView.swift | Switched overlay() to use closure form. |
| MainApp/Setting/CustomKeys/QwertyCustomKeys/QwertyCustomKeysItemView.swift | Refactored both background() and overlay() to closure syntax. |
| MainApp/Setting/CustomKeys/FlickCustomKeys/CustomKeySettingFlickKeyView.swift | Updated background() and overlay() to closure format. |
| MainApp/General/LargeButtonStyle.swift | Converted background() to closure syntax. |
| MainApp/Customize/EditingTenkeyCustardView.swift | Updated overlay() calls with trailing closure blocks. |
| MainApp/Customize/CustomizeTabWalkthrough.swift | Switched overlay() to closure syntax around gear icon. |
| AzooKeyCore/Sources/KeyboardViews/View/QwertyKeyboard/KeyView/QwertyKeyView.swift | Replaced several overlay calls with closures; adjusted overlay alignment. |
| AzooKeyCore/Sources/KeyboardViews/View/KeyboardView.swift | Converted overlay() usage to the closure form. |
| AzooKeyCore/Sources/KeyboardViews/View/KeyboardBar/SliderStyleCursorBar.swift | Updated overlay() to trailing closure style. |
| AzooKeyCore/Sources/KeyboardViews/View/KeyboardBar/ReflectStyleCursorBar.swift | Refactored overlay() calls to closures for better clarity. |
| AzooKeyCore/Sources/KeyboardViews/View/FlickKeyboard/KeyView/FlickKeyView.swift | Updated overlay() to use closure syntax. |
| AzooKeyCore/Sources/KeyboardViews/View/CustomKeybaord/SimpleKeyView/SimpleKeyView.swift | Switched background() and overlay() to use closures. |
| AzooKeyCore/Sources/KeyboardViews/View/Components/ResizingRect.swift | Converted multiple overlay() calls to trailing closure format. |
Comments suppressed due to low confidence (1)
AzooKeyCore/Sources/KeyboardViews/View/QwertyKeyboard/KeyView/QwertyKeyView.swift:250
- Verify that replacing the Group-based overlay with a closure using alignment ('.overlay(alignment: .bottom)') maintains the intended stacking order and visual layout. Double-check that no unintended layout shifts occur due to this refactoring.
.overlay {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #247