Populate the Package notice_text from Scan "key files" #136 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tdruez <[email protected]>
|
@tdruez All my tests in staging were successful. |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is similar to the way a copyright is "inferred" using the
holderdata from the Scan during the "update_from_scan" process when the Dataspace "Update packages automatically from scan" feature is enabled.If a
notice_textis not available directly on the "DETECTED PACKAGE" data returned in the Scan results, the key files content is used to generated content for thenotice_text.Only the key files with "notice" (case is ignored) in their filename are included.
In case of multiple "notice" key files, their content is combined before being assigned to the Package.notice_text