Feature/disposable email blocker on registeration #1620
Conversation
|
i am inspecting this pr now locally |
| user.multiple_mail.error.not_email: 'You must enter a valid email' | ||
| article.status_can_not_be_published_without_author: 'You must to add author before pull article status to published' | ||
| article.status_can_not_be_published_without_author: 'You must to add author before pull article status to published' | ||
| user.invalid.mail.domain: 'Mail have invalid domain address' |
There was a problem hiding this comment.
Invalid implies that user's email domain is not a proper domain. I think we should rather let the user know that their domain is banned.
There was a problem hiding this comment.
@utkuaydin you are right i am correcting now.
| user.multiple_mail.invalid: 'Girdiğiniz adres zaten sistemde kayıtlı' | ||
| user.multiple_mail.error.not_email: 'Geçerli e-mail adresi girmelisiniz' | ||
| article.status_can_not_be_published_without_author: 'Makale durumunu yayınlandıya almadan önce makale yazarı eklemelisiniz.' | ||
| user.invalid.mail.domain: 'E-posta adresinin alan adı geçersiz' |
There was a problem hiding this comment.
Ditto. See my comment for validators.en.yml.
| "ojs/export-bundle": "dev-master", | ||
| "willdurand/js-translation-bundle": "^2.5" | ||
| "willdurand/js-translation-bundle": "^2.5", | ||
| "contentfarm/disposable-email-list":"dev-master" |
There was a problem hiding this comment.
It would be great if the project depended on a specific tag of contentfarm/disposable-email-list instead of dev-master.
There was a problem hiding this comment.
i will make this changes after packagist update. otherwise travis will fail.
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Unnecessary blank lines... 😞
| /** | ||
| * DisposableEmailValidator constructor. | ||
| */ | ||
| public function __construct() |
There was a problem hiding this comment.
Isn't this is unnecessary?
|
@utkuaydin i fixed all reviews. i am merging now. @utkuaydin if you have any other change requests we can continue from this branch |
#1611