Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DartRuffian
Copy link
Contributor

@DartRuffian DartRuffian commented Oct 29, 2024

When merged this pull request will:

  • Title

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

This was on the checklist for #10171
So I'll tag @mrschick if they have any thoughts

@mrschick
Copy link
Contributor

It's a solid step towards better consumables, but by itself it doesn't change much as IIRC there aren't any consumable magazines.
Either way, this change doesn't really conflict with my PR and if it did I'd just rebase my changes on top of this, which I'm not actively working on ATM.

@DartRuffian
Copy link
Contributor Author

DartRuffian commented Oct 29, 2024

This was on the checklist for #10171 So I'll tag mrschick if they have any thoughts

This just adds the existing action to magazines as well, which there aren't any of in ace itself. There's no functionality changes in this PR

@LinkIsGrim LinkIsGrim merged commit ff30851 into acemod:master Nov 2, 2024
3 checks passed
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Nov 2, 2024
@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Nov 2, 2024
@DartRuffian DartRuffian deleted the field_rations/magazine-context-option branch November 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants