Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Dec 22, 2024

When merged this pull request will:

  • Change realistic name's text
  • Variation name of "C-More Camo" is a confusing name if using with RF (has Desert/Woodland Camo for C-More), so Revert the names to "Stripes"
  • C-More and XMS is will be change
  • Also Update Korean localization about RF C-More (For uniformity)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Apricot-ale
Copy link
Contributor Author

RF C-More already has a camouflage version called "Desert/Woodland" (originally Wood). so WS "Stripes" should will be the same. If "Stripes" were to be called the "Camo", it would be confusing because there is already a "Camo" for three.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Dec 22, 2024

Even if this is technically correct, we should use the same suffix as the CDLC and only change the name of the sight/weapon itself. Is that the case here?

@Apricot-ale
Copy link
Contributor Author

Umh, I'm not really sure what he's say correctly (Sorry I'm not native as English), but anyway, this doesn't change the prefixes, it just changes the names given to the color/camo variants to make them more distinguishable.

For example, in XMS, these names were originally as follows:

XMS 5.56mm //Colored as Black
XMS 5.56mm (Gray) //Colored as Gray
XMS 5.56mm (Stripes) //Stripes Camouflaged

However, in the current RealisticName, they are as follows:

XMS
XMS (Gray)
XMS (Camo)

There is no problem with changing "Stripes" to Camo, since there is no other "camouflaged" XMS currently. So this may be fine as it is. but it's nonsence.

However, C-More (ACO) is different.

ACO is as follows in Vanilla:

ACO (Green) //Vanilla, Colored as Black
ACO (Green, Desert) //RF, Arid Camouflaged
ACO (Green, Wood) //RF, Lush Camouflaged
ACO (Green, Stripes) //WS, Stripe Camouflaged

There are three types of camouflage specifications as above.

But Currently in Realistic Name:

C-More Railway (Green)
C-More Railway (Green, Desert)
C-More Railway (Green, Woodland)
C-More Railway (Green, Camo)

"Stripes" will be worsened to not clear what camo it is.
This PR only solves those problem.

BTW: There are also similar name problems in vanilla and GM6.
GM6 Lynx has a Hex(CSAT) version as Camouflage, but it has the name "Camo". Although Green Hex(camo) was added later in Apex, but it is still named as "Camo" not the Hex.
And Snake(camo) was also added by WS, but it is named Snake even in Realistic Name.
However, these are originally by BIS (they forgot to change at APEX Release maybe), and they were not worsened by Realistic Name.
If it was made difficult to understand by Realistic Name, it might have been a problem.

Screenshot on Vanilla

@Apricot-ale
Copy link
Contributor Author

Apricot-ale commented Dec 23, 2024

Hey @Psycool3695 It's been a while.
How do you translate "Stripes" camo in Korean?
If this is merged, the translation will no longer be consistent.

줄무늬 is ok?

@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Dec 24, 2024
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 24, 2024
@Psycool3695
Copy link
Contributor

Hey @Psycool3695 It's been a while. How do you translate "Stripes" camo in Korean? If this is merged, the translation will no longer be consistent.

줄무늬 is ok?

it's difficult to simply translate it as "줄무늬" because that texture is a bit different from the stripes commonly referred to in Korea.
If you absolutely must unify the translation worldwide, I recommend changing that to "줄무늬 위장".

@Apricot-ale
Copy link
Contributor Author

After discussing with Psycool (Korean Translator) on Twitter(X), the Korean translation was completed without any problems, so there is no problem with merging.

@LinkIsGrim LinkIsGrim merged commit 42b45f5 into acemod:master Dec 26, 2024
3 checks passed
@Apricot-ale Apricot-ale deleted the WS-CAMO-Dec24-01 branch March 4, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants