Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wardrobe - New Addon - System to modify wearables #10606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 354 commits into from
Oct 11, 2025
Merged

Wardrobe - New Addon - System to modify wearables #10606

merged 354 commits into from
Oct 11, 2025

Conversation

@OverlordZorn
Copy link
Contributor

@OverlordZorn OverlordZorn commented Dec 27, 2024 •
edited
Loading

When merged this pull request will:

  • New Addon: Wardrobe
    Introduces a new system to modify currently worn gear.

For Example:

  • Roll up/down your sleeves.
  • Raise or lower the visor of helmets.
  • Modify turbans from to the other variants.
  • Combat Goggles <-> Balaclava with Combat Goggles <-> Balaclava

UX:

  • ACE Self Interaction -> Equipment -> Wardrobe (if modifiable Item)
  • Inventory -> CBA Context Menu on Wearable Slot
    • Moved into seperate PR

Compats for: GM, SOG, WS, RF

Related PR's

Documentation

rautamiekka
rautamiekka suggested changes Dec 27, 2024
View reviewed changes
@OverlordZorn OverlordZorn changed the title Wardrobe - New: System to modify current wearables Wardrobe - New Addon - System to modify wearables Dec 28, 2024
rautamiekka
rautamiekka suggested changes Dec 30, 2024
View reviewed changes
@LinkIsGrim LinkIsGrim self-assigned this Dec 31, 2024
@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Dec 31, 2024
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Dec 31, 2024
@OverlordZorn
Copy link
Contributor Author

OverlordZorn commented Jan 2, 2025 •
edited
Loading

Core Features are complete.

@OverlordZorn OverlordZorn marked this pull request as ready for review January 2, 2025 13:12
rautamiekka
rautamiekka suggested changes Jan 2, 2025
View reviewed changes
@Drofseh
Copy link
Contributor

Drofseh commented Jan 2, 2025

all the things with zrn tags need to be changed

DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
DartRuffian
DartRuffian reviewed Jan 3, 2025
View reviewed changes
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jan 3, 2025

Haven't tested nor looked at code yet. How are inherited config properties handled?

@OverlordZorn
Copy link
Contributor Author

OverlordZorn commented Jan 3, 2025

Haven't tested nor looked at code yet. How are inherited config properties handled?

Wearables with fully inherited subclass are ignored.

LinkIsGrim
LinkIsGrim requested changes Jan 3, 2025
View reviewed changes
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jan 3, 2025 •
edited
Loading

Wearables with fully inherited subclass are ignored.

Alright, should be safe then. That should also go in documentation.

LinkIsGrim
LinkIsGrim reviewed Jan 4, 2025
View reviewed changes
LinkIsGrim
LinkIsGrim reviewed Jan 4, 2025
View reviewed changes
LinkIsGrim
LinkIsGrim reviewed Jan 4, 2025
View reviewed changes
LinkIsGrim
LinkIsGrim reviewed Jan 4, 2025
View reviewed changes
@OverlordZorn OverlordZorn mentioned this pull request Jan 4, 2025
Closed
rautamiekka
rautamiekka suggested changes Jan 4, 2025
View reviewed changes
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Sep 30, 2025

Launch parameters can be kept IMO. Would be better if we could skip distributing the mission in CI but I don't think it's a big deal. Maybe move to ./extras like the Adv. Ballistics missions.

BrettMayson
BrettMayson requested changes Sep 30, 2025
View reviewed changes
@BrettMayson
Copy link
Member

BrettMayson commented Sep 30, 2025

Launch parameters can be kept IMO. Would be better if we could skip distributing the mission in CI but I don't think it's a big deal. Maybe move to ./extras like the Adv. Ballistics missions.

We don't ship the .hemtt folder, so they aren't being published

@OverlordZorn OverlordZorn mentioned this pull request Oct 1, 2025
Open
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.20.1 Oct 4, 2025
@OverlordZorn
Copy link
Contributor Author

OverlordZorn commented Oct 4, 2025

@Andx667 😭🥳

LinkIsGrim
LinkIsGrim reviewed Oct 5, 2025
View reviewed changes
PabstMirror
PabstMirror reviewed Oct 8, 2025
View reviewed changes
PabstMirror
PabstMirror reviewed Oct 8, 2025
View reviewed changes
PabstMirror
PabstMirror reviewed Oct 8, 2025
View reviewed changes
@PabstMirror PabstMirror merged commit 8b64aad into acemod:master Oct 11, 2025
3 checks passed
@OverlordZorn OverlordZorn deleted the ace-wardrobe branch October 11, 2025 11:39
@Lupus590 Lupus590 mentioned this pull request Oct 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@Drofseh Drofseh Drofseh left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@Mike-MF Mike-MF Mike-MF approved these changes

@veteran29 veteran29 Awaiting requested review from veteran29

@BaerMitUmlaut BaerMitUmlaut Awaiting requested review from BaerMitUmlaut

@BrettMayson BrettMayson Awaiting requested review from BrettMayson

@johnb432 johnb432 Awaiting requested review from johnb432

+2 more reviewers

@rautamiekka rautamiekka rautamiekka left review comments

@DartRuffian DartRuffian DartRuffian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@LinkIsGrim LinkIsGrim

Labels

kind/feature Release Notes: **ADDED:**

Projects

None yet

Milestone

3.20.1

Development

Successfully merging this pull request may close these issues.

10 participants

@OverlordZorn @Drofseh @LinkIsGrim @BaerMitUmlaut @BrettMayson @rautamiekka @PabstMirror @Mike-MF @johnb432 @DartRuffian