Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jonpas
Copy link
Member

@jonpas jonpas commented Oct 27, 2016

When merged this pull request will:

  • Fix carrying direction for Land_WoodenBox_F.
  • Fix objects with disabled simulation floating on release (ace_common_fnc_fixPosition improvement)
  • Disable collision with nearby players while carrying.

Reason: I got crushed to death yesterday on a mission by a suitcase on one side and a phone on the other. πŸ˜†

Needs testing in multiplayer environment, disableCollisionWith has documented weird requirements about locality, no idea how much of it is true as of now.

Changed implementation to this to the setMass 0 method mentioned by BΓ€r.

In addition to simulation type house, disabled simulation objects will also be floating - this is usually done to prevent clipping or falling of small objects objects through objects they are placed on
@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** target/next-milestone? kind/bug-fix Release Notes: **FIXED:** labels Oct 27, 2016
@jonpas jonpas added this to the 3.8.2 milestone Oct 27, 2016
@commy2
Copy link
Contributor

commy2 commented Oct 28, 2016

Not a fan of each frame nearestObjects, but it's not like you're carrying stuff all the time.

@commy2
Copy link
Contributor

commy2 commented Oct 28, 2016

The array _disabledCollisionObjects should be stored on the object and not on the PFH. That way dropObject_carry can be called from everywhere.
I also don't see this ever being executed on the remote machines. Does it even work like this in MP?
Why is it not done for dragging?

@commy2
Copy link
Contributor

commy2 commented Oct 28, 2016

I suggest making an independant framework for disabling collisions of an object with everything that works in MP and handles JIP.

@jonpas
Copy link
Member Author

jonpas commented Oct 28, 2016

The array _disabledCollisionObjects should be stored on the object and not on the PFH. That way dropObject_carry can be called from everywhere.

Good point.

I also don't see this ever being executed on the remote machines. Does it even work like this in MP?
Why is it not done for dragging?

Dragging doesn't cause collisions like that, I am pretty sure it's because I was testing with a small object, should try something bigger to make sure.

I suggest making an independant framework for disabling collisions of an object with everything that works in MP and handles JIP.

πŸ‘

@jonpas
Copy link
Member Author

jonpas commented Oct 29, 2016

Dragging doesn't seem to be a problem at all (unless you release the object inside someone).

I still need to test how locality works on that command.

@thojkooi thojkooi modified the milestones: 3.8.2, 3.9.0 Nov 17, 2016
commy2
commy2 previously approved these changes Jan 10, 2017
@jonpas
Copy link
Member Author

jonpas commented Oct 11, 2017

Yeah, globally and rerun on each locality change of either object. It seems like I won't have much time to work on this, setting to 3.12, can change back if I do it this weekend.

@jonpas jonpas modified the milestones: 3.11.0, 3.12.0 Oct 11, 2017
@PabstMirror PabstMirror modified the milestones: 3.12.0, Ongoing Nov 29, 2017
@commy2 commy2 self-assigned this Mar 23, 2019
@commy2
Copy link
Contributor

commy2 commented Mar 23, 2019

box setMass 0.000000000001;

@commy2
Copy link
Contributor

commy2 commented Mar 23, 2019

This works in local hosted MP. Client can't damage another client or the host. Mass has be set to >0 however, but that seems to be enough.

@commy2 commy2 removed kind/enhancement Release Notes: **IMPROVED:** status/merge conflict labels Mar 23, 2019
@commy2 commy2 modified the milestones: Ongoing, 3.12.7 Mar 23, 2019
@commy2 commy2 removed the status/WIP label Mar 24, 2019
@commy2
Copy link
Contributor

commy2 commented Mar 24, 2019

Tested, works in MP.

@commy2 commy2 merged commit 4968d90 into master Mar 24, 2019
@commy2 commy2 deleted the draggingFixes branch March 24, 2019 21:14
@PabstMirror PabstMirror modified the milestones: 3.12.7, 3.13.0 Jul 5, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
Disable collision while carrying, Fix floating on disabled simulation objects
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp3 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants