Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@veteran29
Copy link
Member

When merged this pull request will:

  • Wipe glasses self interaction
  • Toggleable via settings (default: false)

@veteran29
Copy link
Member Author

There is one issue right now, despite having exceptions[] = {"notOnMap"}; in config the interaction is visible on the map screen (wanted to hide it there to not clutter the map interaction).

@mharis001
Copy link
Member

It works the other way around, you don't want "notOnMap" to be an exception for the canInteractWith check.

@jonpas
Copy link
Member

jonpas commented Dec 15, 2019

Exceptions are double-negated. In this case "not not on map", resulting in "on map", meaning also show on map. Just remove it as mharis said.

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Dec 16, 2019
@jonpas jonpas added this to the 3.13.1 milestone Dec 16, 2019
@jonpas jonpas modified the milestones: 3.13.1, 3.13.0 Dec 18, 2019
@jonpas jonpas merged commit 7f62067 into acemod:master Dec 18, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp1 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Release Notes: **ADDED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants