Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Medical Status - Only set unconscious upon entering Cardiac Arrest #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Medical Status - Only set unconscious upon entering Cardiac Arrest #7503

merged 1 commit into from
Feb 4, 2020

Conversation

@Whigital
Copy link
Contributor

@Whigital Whigital commented Feb 1, 2020

When merged this pull request will:

  • Set unconsciousness only when entering Cardiac Arrest.

Addresses #7448

@Whigital
Copy link
Contributor Author

Whigital commented Feb 1, 2020 •
edited
Loading

There's a check for unconsciousness in ace_medical_status_fnc_setUnconsciousState,

ACE3/addons/medical_status/functions/fnc_setUnconsciousState.sqf

Line 24 in 2feeec0

if (_active isEqualTo IS_UNCONSCIOUS(_unit)) exitWith { TRACE_2("no change",_active,IS_UNCONSCIOUS(_unit)); };

so adding something like && {!(IS_UNCONSCIOUS(_unit))} feels redundant, or ?

@commy2
Copy link
Contributor

commy2 commented Feb 1, 2020

Does it feel redundant or is it actually redundant? :)

@kymckay
Copy link
Member

kymckay commented Feb 1, 2020

Would be redundant yeah 👍

@kymckay
Copy link
Member

kymckay commented Feb 1, 2020

Have you tested that this is the cause of #7448?

The change should be included either way since it's an unnecessary call, just good to confirm

@Whigital
Copy link
Contributor Author

Whigital commented Feb 2, 2020 •
edited
Loading

Didn't manage to reproduce the issue with the fix in. Then again, i didn't try to reproduce with released code beforehand either so, inconclusive 😕

@commy2
Copy link
Contributor

commy2 commented Feb 2, 2020

Would be nice to have confirmation that after this merged, the issue will be gone as well. Then I can tag this PR as "bug fix" and close the issue.

@kymckay kymckay merged commit cdf02f6 into acemod:master Feb 4, 2020
@Whigital Whigital deleted the ace_medical_cardiacarrest_unconsious_trans branch February 11, 2020 17:17
@PabstMirror PabstMirror added this to the 3.13.1 milestone Feb 22, 2020
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Feb 22, 2020
@jonpas jonpas changed the title [medical_status] Only set unconscious upon entering Cardiac Arrest Medical Status - Only set unconscious upon entering Cardiac Arrest Feb 22, 2020
@PabstMirror PabstMirror mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kymckay kymckay kymckay approved these changes

Assignees

No one assigned

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Milestone

3.13.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Whigital @commy2 @kymckay @PabstMirror