Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@redbery
Copy link
Contributor

@redbery redbery commented Apr 13, 2020

When merged this pull request will:

  • Include vehicles with the tankx simulation type in the water damage fix

Some vehicles (in our case the M119A2) receive damage when loaded on terrains with low elevation. This seems to be the same issue as was already solved for any vehicle using carx simulation, but as these vehicles use tankx instead they do not get made invulnerable.

Simply adding an OR statement for tankx is probably not the cleanest solution, but it appears there are only 3 PhysX simulation types in Arma (last being shipx) so it should be ok. Feel free to suggest a different solution otherwise.

@mharis001 mharis001 added the kind/bug-fix Release Notes: **FIXED:** label Apr 13, 2020
@mharis001 mharis001 added this to the 3.13.2 milestone Apr 13, 2020
@commy2 commy2 merged commit b3f7de9 into acemod:master Apr 14, 2020
@dedmen
Copy link
Contributor

dedmen commented Apr 14, 2020

does the same also apply to other x vehicles? helicopters, jets?
maybe we should just check if simulation ends with "x" ?

@PabstMirror
Copy link
Contributor

thingx
I think we only need this hack for engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants